element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.19k stars 2k forks source link

Customize ringing/notification sound #5891

Open Luraktinus opened 6 years ago

Luraktinus commented 6 years ago

Some users (including me) find this high pitched sound unappealing, please let the users change it or go an octave lower. thank you --Lue

lampholder commented 6 years ago

I wonder - do fb messenger/web whatsapp/slack let you configure notif sounds? Or do they just pick a more universally appealing sound?

hdoupe commented 6 years ago

What's the status on this issue? My colleague and I are testing out the app. It's great so far, but this noise gives me a mini-heart attack every time I get a message.

cc @andersonfrailey

NintendoManiac64 commented 6 years ago

If you're OK with manually doing the process every single time Riot updates, then you can at the very least manually replace the "message.mp3" and "message.ogg" files found at the following location on Windows:

%localappdata%\riot\app-0.17.0\resources\webapp\media

(replace the "0.17.0" text with whatever the newest version of Riot is at any given time; I find it easier to just go to "%localappdata%\riot\" instead and then just manually click through the folders from there)

itay-grudev commented 4 years ago

Here is a link to the newly proposed sound:

:play_or_pause_button: Ringtone by Baptiste Gelez

:play_or_pause_button: Current ringtone (for comparison)

Maffsie commented 4 years ago

I'm in agreement here, the current notification sound for new messages gives me a not-insignificant amount of anxiety every time I hear it, which means I miss notifications because I need to have the sound turned off. Please give users the option of choosing their own tone without having to reapply a manual file swap on every (frequent!) Riot update. @itay-grudev Those audio files appear to be for an incoming call, not for a notification of a new instant message. This issue covers both the ringtone (incoming call) and the notification tone (new message); the linked PR should not close this issue.

Bandie commented 4 years ago

For Arch Linux users: You can manually change out/patch the files in /usr/lib/riot/webapp/media/

t3chguy commented 4 years ago

/usr/lib/riot/webapp/media/

Sounds like you're using some unofficial distribution, official one stores its files in /opt/riot-desktop/

Bandie commented 4 years ago

@t3chguy Well, it seems the package maintainer decided to put things there. (I use arch btw. >:) )

t3chguy commented 4 years ago

Might want to correct your

For Linux users:

Bandie commented 4 years ago

Might want to correct your

For Linux users:

aight

lectrode commented 4 years ago

IMHO, the proposed ringtone is much better than the current. Has a decision been made on whether or not to switch to it?

domoritz commented 3 years ago

Besides changing the default, it would be nice to allow people to choose a sound. That was in https://github.com/vector-im/element-web/issues/6776 and merged into this issue.

monstro1 commented 3 years ago

anyone wanna fix this yet

DanH42 commented 3 years ago

I wonder - do fb messenger/web whatsapp/slack let you configure notif sounds? Or do they just pick a more universally appealing sound?

For starters, none of them uses such a LOUD notification sound. When my system volume is set such that everything else (notifications, videos, etc) is a comfortable volume, an Element notification is borderline painful it's so loud. I have to keep the tab muted and rely on visual cues to tell when I've gotten a message.

A volume control would be great, but custom notification sounds would also allow for an easy workaround that would also satisfy others who don't like the sound itself, regardless of how loud it is.

caniko commented 3 years ago

Why can't we select from a list of ringtones? Why just one default tone?

Please hurry up with the solution, I get anxious every time somebody calls me :dango: (no need to hurry, just trying to be lighthearted)

monstro1 commented 3 years ago

when is someone gonna fix this

i can change the notification sounds for individual rooms, but not the default one. it's unintuitive to have to go into every room and manually replace the sound. atm i've just had to settle with sounds off

igeljaeger commented 3 years ago

welcome to matrix development

ShadowJonathan commented 3 years ago

For what it's worth, there's some more information here: https://github.com/matrix-org/matrix-react-sdk/pull/4500#issuecomment-620942203

While this may be a marked improvement, we wouldn't like to merge this into the project as is. This clashes with some notification work we're (@matrix-org/design) doing internally and any updates to the sounds would have to be part of a pack with variations for multiple contexts, rather than just one sound being changed arbitrarily.

...

As the Design team mentioned above that they'd like to handle this as part of reworking notifications more generally, I don't think it makes sense to keep this open for the moment. We'll keep the sound in mind as we work on notifications.

TLDR; This is still happening, only it's part of the design team's (large) workload, which they'll get to in time. They've already done a lot of work recently to improve the look and feel of Element, most of which equally important as this, so this will happen sometime in the future, just be patient for a little while longer.

sl5net commented 3 years ago

here you could here real sound at my android phone. its not edited. its real sound situation https://www.youtube.com/watch?v=OOulxYMrAPQ

PxBCPG commented 3 years ago

when is someone gonna fix this

i can change the notification sounds for individual rooms, but not the default one. it's unintuitive to have to go into every room and manually replace the sound. atm i've just had to settle with sounds off

Still strange

viasux commented 2 years ago

Please fucking fix this I have like 5 ppl who have all told me that they don't like using the app because of the notification noise and its really really annoying and literally scares some of my friends lmao like how has this been an issue since 2017 I don't get it this is the most basic feature ever, especially when the default noise is so horrid that it physically causes issues for some users.

viasux commented 2 years ago

I wonder - do fb messenger/web whatsapp/slack let you configure notif sounds? Or do they just pick a more universally appealing sound?

For starters, none of them uses such a LOUD notification sound. When my system volume is set such that everything else (notifications, videos, etc) is a comfortable volume, an Element notification is borderline painful it's so loud. I have to keep the tab muted and rely on visual cues to tell when I've gotten a message.

A volume control would be great, but custom notification sounds would also allow for an easy workaround that would also satisfy others who don't like the sound itself, regardless of how loud it is.

literally this, it physically causes pain like I don't get it please fix it so some people can actually use the app, it literally physically makes some people unable to use it.

itay-grudev commented 2 years ago

Hey @itay-grudev & @elegaanz thanks for this contribution!

While this may be a marked improvement, we wouldn't like to merge this into the project as is. This clashes with some notification work we're (@matrix-org/design) doing internally and any updates to the sounds would have to be part of a pack with variations for multiple contexts, rather than just one sound being changed arbitrarily.

We're actually slightly along with choosing some sound packs, but if you'd be interested to talk more feel free to DM me on Matrix: https://matrix.to/#/@nadonomy:matrix.org

How is that work coming along @nadonomy? Maybe consider merging the improved sound from #4500 in the mean time as it has been quite a while now since you posted that.

viasux commented 2 years ago

Sorry if my comment was angry :p I was just upset in the moment, hopefully that doesn't detract from any progress towards this being fixed, sorry.

ShadowJonathan commented 2 years ago

Maybe consider merging the improved sound from #4500 in the mean time

That PR has already been merged a while back, though

aaronraimist commented 2 years ago

They meant https://github.com/matrix-org/matrix-react-sdk/pull/4500 presumably

itay-grudev commented 2 years ago

Correct - matrix-org/matrix-react-sdk#4500. Sorry for that.

c33s commented 2 years ago

this is not only about liking a ringtone or not, the current rington has a physical impact on humans and animals.

to talk via voip i need to set the volume of element to 100% or it is simply to silent to understand the other side. most of the time i forget to reduce the volume after a call to about 15% and the next time someone calls me i nearly get a heart attack. one time the loud noise and the frequency caused a ringing in my ears for a few minutes.

this isn't fun any more. please reduce the volume level in the audio file you are shipping (i can do a PR for that, as i reduced mine by -45db by repacking the asar file) or add a separate volume control for the ring tone and don't wait for the perfect solution with a full blown customized sound-theme.

erogol commented 2 years ago

I honestly hate the notification sound. It irritates me every time. Even if there is a universal sound for every app, I %100 think that the element needs a more welcoming sound than the current one.

thomasfrobieter commented 2 years ago

%localappdata%\riot\app-0.17.0\resources\webapp\media

The mp3 files are gone in current versions? So no possibility to replace em manually anymore?

Flam3z commented 2 years ago

The ringing sound really hurts my ears, I hope its just a temp change.

t3chguy commented 2 years ago

They're in the webapp.asar, you can modify the package using asar tooling.

mmance commented 2 years ago

I can't believe people have been listening to that awful ringtone for over 5 years.

bb010g commented 2 years ago

What work needs to happen to resolve this issue? Is there a simple patch / set of patches that could be merged to resolve this? Has design figured out what they want notification control to (mostly) work like, but that hasn't been implemented yet? Is this issue completely blocked on design, and these people's problems won't be fixed until design figures out new notification control and that's implemented?

It's not clear to me where this issue really is right now.

itay-grudev commented 2 years ago

@bb010g I made a PR a while ago. They just didn't want it, saying they were working on something of their own. They just never released it in the last several years.

ShadowJonathan commented 2 years ago

This issue has been open for a long while, while no attention has been given to it by the team or by Product.

While for me personally the sound is relatively bearable, some friends have noted that the sound is annoying, gives anxiety, or is downright unbearable on their ears.

However, it also appears that currently it is not possible to change the global notifications sound, the possible way to do this is to change the application files themselves.

This exasperates this issue, and makes it very likely that people will not stay on Element due to aforementioned problems they have when receiving notifications, leading them to wane on its usage.

kellyclowers commented 2 years ago

Please fix this, the current sound is unbearable. Change it something less horrible, let us select from a few, let us easily replace the file... something!

Also do the Devs not dogfood the client? or are they all just 90% deaf? You'd think any person of average hearing would be greatly incentivized to change it...

numanair commented 2 years ago

I have stopped using Element because of this issue. It is literally unbearable.

ShadowJonathan commented 2 years ago

I understand that for Element it is hard to change - what is essentially - part of their brand.

However, at the very least the interface for someone to change their notification sound should be exposed, https://github.com/vector-im/element-web/issues/20286 is this feature request, and this feature is already in the code, as detailed here, the only thing missing is UI that would change that settings value.

mibmo commented 2 years ago

@bb010g I made a PR a while ago. They just didn't want it, saying they were working on something of their own. They just never released it in the last several years.

Could you perhaps link your PR? We might be able to bump it.

aselus-hub commented 2 years ago

just want to chime in that this is bad, I know a lot of people that outright don't want to use element or just silence it so it's impossible to use due to the sound it makes, which is a prime example of how this hurts adoption. Can we please get some official word on this and the proposed "other change"?

nuke-web3 commented 2 years ago

At the very least the interface for someone to change their notification sound should be exposed, #20286 is this feature request, and this feature is already in the code, as detailed here, the only thing missing is UI that would change that settings value.

is it possible without building source locally to use this via, say a cli command? Really anything at his point so I can keep some sound on. I have to mute the present sound - it hurts me (wince every time)

mibmo commented 2 years ago

If all that's missing is the UI, would anyone be willing to pick this up and churn through it? Seems (almost deceptively) simple. Just a few file pickers?

TristanCottam commented 2 years ago

Having an option to change the ringing sound, despite being optimal, is less important than changing the default sound itself. Many users would be turned off by hearing this sound in the first place, some of them dropping the app altogether without bothering to look for such a setting, let alone expecting such a setting to even exist.

Even a basic looping beep would suffice, and would furthermore probably be the most universally user-friendly solution.

First impressions outweigh customizability.

mibmo commented 2 years ago

For reference, these instructions currently work, but it's not exactly ideal.

@tristan-cottam: First impressions outweigh customizability.

Not a bad take. Do you have anything specific in mind? I think I'll pick this issue up, starting with customisation.

TristanCottam commented 2 years ago

Even a basic looping beep would suffice, and would furthermore probably be the most universally user-friendly solution.

If this not what you were asking for, please detail your expectancies.

mibmo commented 2 years ago

Woops, yes! note to self: don't work on OSS in the middle of the night! Are you referring to the ringing or notification sound though? what you're describing definitely wouldn't work for notifications (at least the way I'm imagining it). Nonetheless if you can produce it yourself then an audio file (with accompanying compatible license) would be very nice :)

Alkalurops commented 2 years ago

How is this not fixed. I'm going to stop using this. It's unbearable with the sound and useless without a notification.

viasux commented 2 years ago

How is this not fixed. I'm going to stop using this. It's unbearable with the sound and useless without a notification.

yeah I exclusively use signal for voice calls now, it was too horrendous to deal with..

alternatively, cinny.in is a good text only matrix client

ThiefMaster commented 2 years ago

This is an absolute must have, with separate sounds for message and calls (ideally separate choices for all different sounds!).

My 80-year-old dad is using Element on his PC, smartphone and tablet. He does NOT always carry the phone with him at home (and good luck convincing someone of that age to change their habits). So when there's the short windows notification sound and he's in the room next to the one with his PC or watching TV in the same room (somewhat loudly since his ears aren't the best anymore), he does NOT notice the notification sound and ends up missing the message until he sees it on the PC.

With configurable sounds he would simply pick a longer one and even though personally I would find that super annoying for new incoming messages, he'd certainly notice it when it's not just such a short noise.

TL;DR: Please let people choose their sounds.

(unrelated to my argument: I also don't like the default ringtone very much)