search

element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.02k stars 1.96k forks source link

Honour keyshare requests from people you sent messages to. #7427

Closed ara4n closed 2 years ago

ara4n commented 5 years ago

We apparently request keyshares from sending devices (as well as ourselves), but the sender ignores them like this:

2018-08-31T14:52:31.714Z I m.room_key_request from @Amandine:matrix.org:ZNPRXEQNQD for !teBWTcboSifjyWqxfY:matrix.org / f7mPJ4rZe3p8fuBpaOZL/SP1e6YQfXYtLlgP46mh2mU (id m1535727143583.162)
2018-08-31T14:52:31.714Z I Ignoring room key request from other user for now

If we actually upheld them, it'd work around a bunch of UISIs. If the sender can work out whether it's safely allowed to honour the req, it should.

turt2live commented 2 years ago

I believe the behaviour here has dramatically changed, and is pre-cross-signing.

Considering a duplicate of https://github.com/vector-im/element-meta/issues/1888