element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.02k stars 1.96k forks source link

Room settings should not be fully displayed to non privileged users #764

Closed AmandineLP closed 8 years ago

AmandineLP commented 8 years ago

Only the settings relevant to the user's privileges should be displayed

ara4n commented 8 years ago

@AmandineLP are you happy for them to just be greyed out? Or do we really want to hide the config capabilities from mortal users?

AmandineLP commented 8 years ago

greyed out is fine for now but hiding them would be good in the future from a decluttering perspective.

AmandineLP commented 8 years ago

non-privileged users includes guests obviously

dcampbell24 commented 8 years ago

I am planning to work on this over the weekend.

I don't know that we actually want to hide the settings since that would make it harder for the user to know what the current settings are. By "greyed out" I am taking that to mean set the disabled attribute on the widget.

ara4n commented 8 years ago

this got fixed.

dcampbell24 commented 8 years ago

:+1: