element-hq / element-web

A glossy Matrix collaboration client for the web.
https://element.io
GNU Affero General Public License v3.0
11.01k stars 1.96k forks source link

Feature Request: Option to disable media embeds #8790

Closed BurnyBoi closed 5 years ago

BurnyBoi commented 5 years ago

Description

When I use Riot at work, I don't want to see images or videos pop up on my screen. Someone could potentially post something NSFW.

It would be helpful if, similar to Discord, there was a user setting to not embed videos and pictures uploaded directly to Matrix. When enabled, if someone uploads an embeddable file, it should show a placeholder with a link to view/download it, similar to what happens when someone uploads a non-embeddable file like a .txt file. I tried setting URL previews to off in a room, but understandably this doesn't affect media uploaded directly to Matrix.

As a workaround, I'm currently using uMatrix to block all images on the page. This also hides room/user avatars though, so it's not ideal.

aaronraimist commented 5 years ago

Sounds like vector-im/element-meta#1257/#2466

BurnyBoi commented 5 years ago

vector-im/element-web#2466 makes it sound like the images should still display by default, but then allow you to hide them per-image after the fact. I think it should work the opposite, where you can choose to hide them by default, then have a button to show them if you want to see.

vector-im/element-meta#1257 sounds more like it, but this should apply to videos too, since Riot displays the first frame of the video behind the play button.

BurnyBoi commented 5 years ago

I added my comment about videos to vector-im/element-meta#1257, and will continue the discussion there as needed. Thanks for linking those other issues.