Context menu clashes with Android's soft menu buttons - Githubissues

element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose

GNU Affero General Public License v3.0

1.08k stars 155 forks source link

Context menu clashes with Android's soft menu buttons #1081

Open ara4n opened 1 year ago

ara4n commented 1 year ago

Steps to reproduce

Long tap on a message
Observe the pretty context menu
The menu however has Android's switcher/home/back softbuttons overlaid at the bottom, which feels like a nasty clash of overlapping OS v app UI:

Screenshot 2023-08-17 at 22 55 53

Outcome

What did you expect?

Surely it should either overlay the buttons entirely, or the context menu shouldn't reach down that far.

What happened instead?

The fact that both UIs overlap and get entangled feels bleeeeeeurgh.

Your phone model

S10

Operating system version

12 (OneUI 4.1)

Application version and app store

0.1.2 playstore

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

jmartinesp commented 1 year ago

This seems like a bug in the component that we can't actually fix:

The bottom sheet is displayed in a custom full screen window that overlays the current one. And by full screen I mean literally the whole screen, system bars included.
We can provide a windowInsets property that offsets the contents, but only at its final position.
We have no way to access that window AFAICT.
We can't ask the contents to clip to their bounds, it just displays nothing.
Adding padding to the contents of the bottom sheet doesn't fix this.
Adding custom insets doesn't help.

We can only wait for Google to fix this component.