element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose
GNU Affero General Public License v3.0
1.08k stars 155 forks source link

RTL support #1256

Open FarisZR opened 1 year ago

FarisZR commented 1 year ago

Your use case

What would you like to do?

It would be great if the entire app supports an RTL layout, but its good enough if it supports rtl content in messages and the text box.

Why would you like to do it?

not a dev sorry.

How would you like to achieve it?

start with RTL content support, then add an RTL layout to the entire app.

Have you considered any alternatives?

No response

Additional context

the current way the original Element app handels RTL is fine, telegram does it well too.

Are you willing to provide a PR?

No

FarisZR commented 9 months ago

An update, element X now supports RTL direction in messages, however Text in the replied-to message is still always LTR.

At least the app is usable for me now.

bmarty commented 3 weeks ago

An update, element X now supports RTL direction in messages, however Text in the replied-to message is still always LTR.

At least the app is usable for me now.

Hello @FarisZR, can you share a screenshot with the problem please? It seems to work fine on my side. Thanks!

FarisZR commented 3 weeks ago

Sure, here is an example with the flipped part highlighted.

Screenshot_20241015-111014

bmarty commented 3 weeks ago

Thanks. In your screenshot:

In the in replied content above the composer, I can maybe remove the text alignement, which is set to Start to let the system decide regarding the content of the text to render.

For the In replied to part above the composer, when the app is in Rtl mode, the rendering is fine, you can check it here: https://element-hq.github.io/element-x-android/?l=fa#TextComposerReply

FarisZR commented 3 weeks ago

Thanks for the reply.

That's true, the app is in an LTR language, but it should still handle mixed content correctly, such issues don't happen in other apps like whatsapp.

-------- Ursprüngliche Nachricht -------- Am 16.10.24 12:20 um Benoit Marty - notifications at github.com schrieb :

Thanks. In your screenshot:

  • The application is not currently in Rtl mode. The read receipt should be on the left of the screen and here they are on the right.
  • The message contains Rtl text and in this case, I believe that the system try to render such text using Rtl orientation. But it also contain Ltr word ("image"), see maybe the system is getting confused.

In the in replied content above the composer, I can maybe remove the text alignement, which is set to Start to let the system decide regarding the content of the text to render.

For the In replied to part above the composer, when the app is in Rtl mode, the rendering is fine, you can check it here: https://element-hq.github.io/element-x-android/?l=fa#TextComposerReply

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>