Duplicated strings - BLOCKED UNTIL THE 2 APPS HAVE SAME FLOW

bmarty commented 1 year ago

There is an issue on Strings between iOS and Android application.

On Android, some strings have been added for submit buttons, like for instance:

https://github.com/vector-im/element-x-android/blob/develop/features/login/impl/src/main/res/values/localazy.xml#L40

<string name="screen_account_provider_continue">"Continue"</string>

instead of using the generic string https://github.com/vector-im/element-x-android/blob/develop/libraries/ui-strings/src/main/res/values/localazy.xml#L19

<string name="action_continue">"Continue"</string>

The value is the same in English, but translations can differ (maybe not for this particular example though), which is not what we want.

We should simplify by removing the extra string entries, and use the generic value when it exists. It will reduce the number of strings to translate and will ensure that Android and iOS are synced. The drawback is that it will not be possible to tweak a value for a particular string by just updating Localazy.

We can use the find duplicate facilities on Localazy to detect identical strings, and probably remove all the duplicates.

bmarty commented 12 months ago

String to remove from Localazy when the PR will be merged:

[x] screen_account_provider_continue (replaced by action_continue)
[x] screen_change_server_submit (was not used)
[ ] screen_change_server_title (was not used) I Actually restored this one, used on iOS now (not used on Android)
[x] screen_login_submit (replaced by action_continue)
[x] settings_title_general (not used)
[x] screen_settings_oidc_account (not used)
[x] rageshake_dialog_content (not used, we are using rageshake_detection_dialog_content)
[ ] ~~common_verification_cancelled (we are using screen_session_verification_cancelled_title)~~
[x] screen_session_verification_positive_button_ready (replaced by action_start)
[x] screen_room_details_people_title (replaced by common_people)
[x] screen_login_password_hint (replaced by common_password)
[x] screen_login_username_hint (replaced by common_username)
[ ] common_select_your_server (we use screen_change_server_title) This one is already deleted 🤔
[x] screen_onboarding_subtitle (unused)

@pixlwave can you double check that this will not impact iOS if I remove the strings above?

pixlwave commented 12 months ago

From the above, we are using the following on iOS:

common_verification_cancelled: this seems valid to me given it could easily be used in other scenarios (e.g. verifying other users). We also use common_verification_complete too.
common_select_your_server: this is linked with screen_change_server_title anyway, so maybe not desperate if we have both, but happy to update iOS if you think it would be better.

bmarty commented 12 months ago

Other string to remove: