New messages in timeline no longer appear with an animation

rom4nik commented 8 months ago

Steps to reproduce

Send or receive a message.

Outcome

What did you expect?

New messages have a "slide in" animation, like they used to a few versions ago.

What happened instead?

https://github.com/element-hq/element-x-android/assets/46846000/e42ec5d9-90e2-4a5e-9990-fdb045e5355f

Your phone model

Google Pixel 7 Pro

Operating system version

Android 14

Application version and app store

v0.4.5 release build

Homeserver

Synapse v101.0

Will you send logs?

No

Are you willing to provide a PR?

No

jmartinesp commented 8 months ago

This animation was automatic AFAICT (we don't have any explicit code for it) so it's weird that it's now gone. Do you remember in which version this was working as expected?

I suspect adding the typing notifications may be related to it since they are now at the bottom of the timeline, but I'm not 100% sure.

frebib commented 6 months ago

I was just playing around with Francois' jump-to-message implementation and noticed that the animation works again on that branch. I presume it's because the typing notifications were disabled https://github.com/element-hq/element-x-android/compare/develop...feature/fga/permalink_timeline#diff-594345b3940e91c8414ebe16d73e789d073cb7f057f03b7e9dc4d0941bc97096R132-R137

frebib commented 6 months ago

I've spent some time pondering this over the last couple of days and I have a few thoughts

I'm reasonably sure that this is because the TypingNotificationView is the first item in the LazyColumn, so there is no attempt to animate adding an new messages into view, because the typing indicator is below it. The Jetpack Compose documentation seems to be pretty sparse/shit at best, but I can't find any notion that these default animations are even a thing (assuming they are standard functionality and not something Element added). There seems to be very little that can be done at least with the way it's currently implemented.
An easy-ish way to fix this would be to move the TypingNotificationView out of the LazyColumn at the cost of it always appearing regardless of the scroll position. I do think the animations warrant some more work either way so it's probably not worth doing that.
Playing around with the animations as-is with the TypingNotificationView removed, they're pretty glitchy, mostly because of the read receipts jumping around as messages appear/are read. It'd be neat if they slide gracefully like they do in EW, but again I think the current view structure kinda makes that hard to change (at least with my limited knowledge of how Jetpack Compose works.. it may be possible). It'd need design mockups anyway

element-hq / element-x-android