search

element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose
GNU Affero General Public License v3.0
1.1k stars 156 forks source link

[Task] Unify the way we decide when a room is actually a DM #3078

Open jmartinesp opened 5 months ago

jmartinesp commented 5 months ago

Some time ago we took a decision to enforce DMs being only "direct rooms with at most 2 users, encrypted".

As we developed the app, we apparently duplicated the computation of this value in several places (here, here, here... and in other many places, with different outputs) so we should try to ensure consistency.

BeowulfR commented 2 months ago

I think this is a wrong, thoughtless decision (that only encrypted rooms with a maximum of 2 people are DMs).

Why?

  1. it ignores the decision of us users. In many clients (Element Web, Element Desktop, Nheko, etc) you have the commands “converttodm” and “converttoroom”, these decisions of the user are ignored and lead to inconsistent behavior.

  2. matrix always mentions its great advantage of bridges. However, these are devalued by this decision. Every bridged DM becomes a room instead of a DM. This has a lasting negative impact on the UX, as I expect to see my signal DM, for example, when I filter by DMs.

I hope the decision will be reconsidered...