search

element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose
GNU Affero General Public License v3.0
1k stars 136 forks source link

Element X allows D2D backups #3465

Open lucasmz-dev opened 1 week ago

lucasmz-dev commented 1 week ago

Steps to reproduce

  1. Backup using Seedvault on D2D mode
  2. Element X atores a significant amount of data
  3. Backup without D2D mode
  4. Element X does not backup anything

Outcome

What did you expect?

The older regular does not use the Android backup API at all, and blocks any attempts, hence I would've expected the same for X.

What happened instead?

Backups are allowed in D2D mode.

Your phone model

Moto G52

Operating system version

Android 14

Application version and app store

Element X 6.0

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

lucasmz-dev commented 1 week ago

This might not be necessarily a defect, Element could decide D2D are safe and perhaps use them. One thing I haven't tested is restoring these, would it work or would some encryption key get lost?

Mostly I'm pointing this out due to it being different from regular Element. The only real way it affects me is that it backs up 300MB of which I really don't need, but that's somewhat expected out of D2D mode on Seedvault which pretends to be a D2D transfer.

bmarty commented 1 week ago

Backup is disabled on Element Android and on Element X (see https://github.com/element-hq/element-x-android/blob/main/app/src/main/AndroidManifest.xml#L16). Is there something I am missing here?

lucasmz-dev commented 1 week ago

That works for regular cloud backups, but it doesn't cover D2D (device to device) transfers

Regular Element managed to exclude that