element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose
GNU Affero General Public License v3.0
1.08k stars 155 forks source link

Fix not being able to decline an invite from the room list #3466

Closed jmartinesp closed 2 months ago

jmartinesp commented 2 months ago

Content

Motivation and context

Fixes https://github.com/element-hq/element-x-android/issues/3407.

Note the implementation is a quick fix and some iteration on this issue is encouraged: ideally, we'd have JoinedRoom and InvitedRoom abstractions that share a minimum of logic, and maybe both implement a simplified MatrixRoom.

Tests

Tested devices

Checklist

github-actions[bot] commented 2 months ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bmu7yp

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.63%. Comparing base (764692b) to head (499aaef).

Files with missing lines Patch % Lines
...vite/impl/response/AcceptDeclineInvitePresenter.kt 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3466 +/- ## ======================================== Coverage 82.63% 82.63% ======================================== Files 1701 1702 +1 Lines 40047 40055 +8 Branches 4872 4872 ======================================== + Hits 33092 33100 +8 Misses 5234 5234 Partials 1721 1721 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.