Closed jmartinesp closed 2 months ago
:iphone: Scan the QR code below to install the build (arm64 only) for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/bmu7yp
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Attention: Patch coverage is 90.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 82.63%. Comparing base (
764692b
) to head (499aaef
).
Files with missing lines | Patch % | Lines |
---|---|---|
...vite/impl/response/AcceptDeclineInvitePresenter.kt | 50.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Content
RoomListItem.invitedRoom()
API to get a room in an invited membership state that won't need a timeline to work.AcceptDeclineInvitePresenter
get an invited room instead of the full room and decline the invite.Motivation and context
Fixes https://github.com/element-hq/element-x-android/issues/3407.
Note the implementation is a quick fix and some iteration on this issue is encouraged: ideally, we'd have
JoinedRoom
andInvitedRoom
abstractions that share a minimum of logic, and maybe both implement a simplifiedMatrixRoom
.Tests
Tested devices
Checklist