Temporary account creation using Element Web.

bmarty commented 2 months ago

Content

Add ability to create an account directly from Element X, but using a Url of an Element Web instance.

Motivation and context

Give a temporary way for users to create account, waiting for MAS to be available on matrix.org.

Screenshots / GIFs

AccountCreation

Tests

Note: account creation on matrix.org needs that the URL https://matrix.org/.well-known/element/element.json return some Json. In the mean time, this is possible to test by letting DefaultWebClientUrlForAuthenticationRetriever.retrieve return the value "https://pr42--matrix-react-sdk.netlify.app/#/mobile_register"

Using password

Start the app
Click on "Create an account"
Use matrix.org
Click on Continue
follow the flow to create the account
at the end the account has been created and, the (empty) room list should be displayed

Using Oidc

Start the app
Click on "Create an account"
Change the homserver to an Oidc-support server
Click on Continue
follow the flow to create the account
at the end the account has been created and, the (empty) room list should be displayed

Tested devices

[ ] Physical
[x] Emulator
OS version(s):

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[ ] Pull request is based on the develop branch
[ ] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR

github-actions[bot] commented 2 months ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/npMpQT

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 60.16598% with 96 lines in your changes missing coverage. Please review.

Project coverage is 82.52%. Comparing base (764692b) to head (7f1d9bb). Report is 26 commits behind head on develop.

Files with missing lines	Patch %	Lines
...in/impl/screens/createaccount/CreateAccountView.kt	53.62%	30 Missing and 2 partials :warning:
...screens/createaccount/WebViewMessageInterceptor.kt	0.00%	27 Missing :warning:
...impl/web/WebClientUrlForAuthenticationRetriever.kt	0.00%	20 Missing :warning:
...nfirmaccountprovider/ConfirmAccountProviderView.kt	25.00%	8 Missing and 1 partial :warning:
...creens/createaccount/MobileRegistrationResponse.kt	20.00%	4 Missing :warning:
...es/login/impl/resolver/network/ElementWellKnown.kt	0.00%	2 Missing :warning:
...pl/screens/createaccount/CreateAccountPresenter.kt	93.93%	1 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3467 +/- ## =========================================== - Coverage 82.63% 82.52% -0.11% =========================================== Files 1701 1713 +12 Lines 40047 40275 +228 Branches 4872 4899 +27 =========================================== + Hits 33092 33237 +145 - Misses 5234 5314 +80 - Partials 1721 1724 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.