Account deactivation. - Githubissues

bmarty commented 1 week ago

Content

Add ability for the user to delete the account in-app, if this is a password based account.

Figma: https://www.figma.com/design/A2pAEvTEpJZBiOPUlcMnKi/Settings-%2B-Room-Details-(new)?node-id=1958-12130&node-type=instance&m=dev

Motivation and context

Now the the application is able to create account, we need to provide a way to delete it.

Screenshots / GIFs

AccountDeactivation

Notes:

I do not know why the first icon in the list is not tinted, probably a cache issue. Let's see how the screenshots are getting recorded. (note: this is fixed now)
the "Deactivate" button in the confirmation dialog is now red (destructive)

Tests

Create an account (can be done in-app on matrix.org)
Navigate to the setting a deactivate the account

Observe that the account has been deleted (this is not possible to login again) and the application is back to fresh install state.

Tested devices

[ ] Physical
[x] Emulator
OS version(s):

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[ ] Pull request is based on the develop branch
[ ] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR

github-actions[bot] commented 1 week ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/DzTBk3

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 89.55224% with 28 lines in your changes missing coverage. Please review.

Project coverage is 82.65%. Comparing base (b94a5c9) to head (782e1e3). Report is 7 commits behind head on develop.

Files with missing lines	Patch %	Lines
...id/features/logout/impl/AccountDeactivationView.kt	86.33%	13 Missing and 6 partials :warning:
.../logout/impl/ui/AccountDeactivationActionDialog.kt	82.35%	1 Missing and 2 partials :warning:
...atures/logout/impl/AccountDeactivationPresenter.kt	93.75%	1 Missing and 1 partial :warning:
...ogout/impl/DefaultAccountDeactivationEntryPoint.kt	0.00%	2 Missing :warning:
...t/impl/ui/AccountDeactivationConfirmationDialog.kt	87.50%	1 Missing :warning:
...tures/preferences/impl/root/PreferencesRootView.kt	83.33%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3479 +/- ## =========================================== + Coverage 82.58% 82.65% +0.07% =========================================== Files 1723 1731 +8 Lines 40566 40829 +263 Branches 4942 4964 +22 =========================================== + Hits 33501 33749 +248 - Misses 5317 5320 +3 - Partials 1748 1760 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

bmarty commented 1 week ago

OK, here is the updated design: