Fix sliding sync proxy login not working after native SS failure

jmartinesp commented 1 week ago

Content

Catch right exception for retrying the HS setup with sliding sync proxy after native sliding sync failed.

Motivation and context

The wrong exception was being caught and the fallback mechanism wasn't properly working.

Tests

Use a HS without native sliding sync, such as riot.grin.hu.
Try to log in with the SSS toggle enabled.
It should work, but using the sliding sync proxy (you can check this in the logs).

Tested devices

[x] Physical
[ ] Emulator
OS version(s): 14

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[x] Pull request is based on the develop branch
[x] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[x] You've made a self review of your PR

github-actions[bot] commented 1 week ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/hcYvLk

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.67%. Comparing base (7922243) to head (712f11b). Report is 1 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3489 +/- ## ======================================== Coverage 82.67% 82.67% ======================================== Files 1731 1731 Lines 40841 40841 Branches 4968 4968 ======================================== Hits 33764 33764 Misses 5315 5315 Partials 1762 1762 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

element-hq / element-x-android