Room list : debounce subscribe to visible rooms.

element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose

GNU Affero General Public License v3.0

1.08k stars 155 forks source link

Room list : debounce subscribe to visible rooms. #3491

Closed ganfra closed 1 month ago

ganfra commented 1 month ago

Content

Avoid cancelling sync request too often because we subscribe to visible rooms by adding a debounce.

Motivation and context

Screenshots / GIFs

Tests

Step 1
Step 2
Step ...

Tested devices

[ ] Physical
[ ] Emulator
OS version(s):

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[ ] Pull request is based on the develop branch
[ ] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR

github-actions[bot] commented 1 month ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/yUKA1A

jmartinesp commented 1 month ago

LGTM, but it seems that some test(s) are failing

I fixed those in https://github.com/element-hq/element-x-android/pull/3491/commits/4b2ea110371974fcd62f0768ac6502370bd8137b, added a separate test for cancellation 🤞 .

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.67%. Comparing base (2d31308) to head (4b2ea11). Report is 5 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3491 +/- ## ======================================== Coverage 82.67% 82.67% ======================================== Files 1731 1731 Lines 40841 40842 +1 Branches 4968 4968 ======================================== + Hits 33764 33766 +2 Misses 5315 5315 + Partials 1762 1761 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.