Test RustMatrixClient and other classes in the matrix module

element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose

GNU Affero General Public License v3.0

1.08k stars 155 forks source link

Test RustMatrixClient and other classes in the matrix module #3501

Closed bmarty closed 1 month ago

bmarty commented 1 month ago

Content

More tests on the :matrix:impl module and small fixes in the codebase.

Note: everything is not tested, this PR is added the skeleton to add more test in the future.

Motivation and context

Improve code coverage and code quality.

Screenshots / GIFs

Tests

Should not impact application behavior

Tested devices

[ ] Physical
[x] Emulator
OS version(s):

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[ ] Pull request is based on the develop branch
[ ] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR

github-actions[bot] commented 1 month ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/d5HDQm

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.67%. Comparing base (929cefa) to head (88a30eb). Report is 28 commits behind head on develop.

Files with missing lines	Patch %	Lines
...ications/DefaultOnMissedCallNotificationHandler.kt	0.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3501 +/- ## ======================================== Coverage 82.67% 82.67% ======================================== Files 1731 1731 Lines 40843 40844 +1 Branches 4968 4968 ======================================== + Hits 33766 33768 +2 Misses 5315 5315 + Partials 1762 1761 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.