Open frebib opened 1 week ago
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
origin/develop
, at least when it was created../gradlew test
../gradlew runQualityChecks
.Record screenshots
GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.Attention: Patch coverage is 61.76471%
with 13 lines
in your changes missing coverage. Please review.
Project coverage is 82.64%. Comparing base (
cc1cee8
) to head (bf360d8
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
One small issue with this implementation is the snackbars don't appear until the view is closed.. not sure why, because I copy-pasted some other code that does the same thing and it works fine. Coroutines in Kotlin are ~shit~ weird. Suggestions welcome šš»
You need the View where SnackBar may be rendered to have a SnackBarHost.
You can look for val snackbarHostState = rememberSnackbarHostState(snackbarMessage = state.snackbarMessage)
in the code base and add the code to all the View which may have to render a Snackar. I know this is painful :).
Perfect, thanks Benoit. I'll give that a go in a few days and see how I get on
Content
Make user id and room alias text in room/user view pages clickable and copy the text to the clipboard on click.
One small issue with this implementation is the snackbars don't appear until the view is closed.. not sure why, because I copy-pasted some other code that does the same thing and it works fine. Coroutines in Kotlin are ~shit~ weird. Suggestions welcome šš»
Motivation and context
Fixes https://github.com/element-hq/element-x-android/issues/3496
(Do note that I have no idea what I'm doing.. I merely mimic what I see until it works)
Screenshots / GIFs
https://github.com/user-attachments/assets/50915a67-b92f-467d-8c1f-ec93fa00a83a
Tests
Finger touchy screeny
Tested devices
Checklist