Include inviter in the notification for invitation

bmarty commented 1 month ago

Content

Include the sender name (or id) in the notification for invitation.

Second commit is test cleanup.

Motivation and context

More useful notification

Screenshots / GIFs

Before	After

Note: rendering on iOS:

Tests

Get invited to a room or to a DM and observe the content of the notification

Tested devices

[ ] Physical
[x] Emulator
OS version(s):

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[ ] Pull request is based on the develop branch
[ ] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR

github-actions[bot] commented 1 month ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/gpfhAd

sonarcloud[bot] commented 1 month ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.67%. Comparing base (dfe9323) to head (6fc801e). Report is 32 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3503 +/- ## ======================================== Coverage 82.67% 82.67% ======================================== Files 1731 1731 Lines 40844 40852 +8 Branches 4968 4968 ======================================== + Hits 33768 33775 +7 Misses 5315 5315 - Partials 1761 1762 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

element-hq / element-x-android