search

element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose
GNU Affero General Public License v3.0
1.05k stars 150 forks source link

Message with msgtype = m.notice renders like regular message #3636

Open bmarty opened 2 weeks ago

bmarty commented 2 weeks ago

Steps to reproduce

  1. observe how a m.notice message is rendered in a timeline

Outcome

What did you expect?

It should render differently than regular messages.

What happened instead?

m.notice are rendered as regular messages.

Note: EX iOS is rendering a info picto on the left of the message, but I can't find any design about this. Element Web is rendering m.notice using secondary text color. @amshakal can you help please?

Your phone model

any

Operating system version

any

Application version and app store

all

Homeserver

any

Will you send logs?

No

Are you willing to provide a PR?

Yes

manuroe commented 2 weeks ago

EXI has it since the very beginning. I am not sure if we followed a design. @stefanceriu do you remember?

It is how it currently looks like on iOS: image

stefanceriu commented 2 weeks ago

EXI has it since the very beginning. I am not sure if we followed a design. @stefanceriu do you remember?

The layout is pretty much the same since the beginning and we tweaked the icon a while back https://github.com/element-hq/element-x-ios/pull/2120/files#diff-20891962bb851e50bf0321b0732a4ccc28a1664119872e35bc2d37d037ce407f