element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose
GNU Affero General Public License v3.0
1.08k stars 155 forks source link

Add userId in identity change warning banner #3686

Closed bmarty closed 1 month ago

bmarty commented 1 month ago

Content

Ensure userId is displayed in the warning about identity changed banner.

Motivation and context

Closes #3678

Screenshots / GIFs

See the recorded ones.

Tests

Tested devices

Checklist

github-actions[bot] commented 1 month ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/15Rk8i

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.81%. Comparing base (717d1b2) to head (6392404). Report is 11 commits behind head on develop.

Files with missing lines Patch % Lines
...mpl/crypto/identity/IdentityChangeStateProvider.kt 85.71% 2 Missing :warning:
...nt/android/libraries/matrix/api/room/RoomMember.kt 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3686 +/- ## ======================================== Coverage 82.81% 82.81% ======================================== Files 1748 1748 Lines 41777 41804 +27 Branches 5108 5109 +1 ======================================== + Hits 34597 34622 +25 - Misses 5365 5366 +1 - Partials 1815 1816 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.