element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose
GNU Affero General Public License v3.0
1.08k stars 155 forks source link

Feature: knock request to join #3725

Closed ganfra closed 3 weeks ago

ganfra commented 3 weeks ago

Content

This is the first iteration for the request to join feature. Currently, missing parts are :

Motivation and context

Partially handles https://github.com/element-hq/element-x-android/issues/3690

Screenshots / GIFs

Tests

Tested devices

Checklist

github-actions[bot] commented 3 weeks ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GTtXee

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 89.50820% with 32 lines in your changes missing coverage. Please review.

Project coverage is 83.02%. Comparing base (26da0f3) to head (7588b4e). Report is 28 commits behind head on develop.

Files with missing lines Patch % Lines
...ent/android/features/joinroom/impl/JoinRoomView.kt 92.04% 12 Missing and 2 partials :warning:
...droid/features/joinroom/impl/di/CancelKnockRoom.kt 0.00% 5 Missing :warning:
...ent/android/features/joinroom/impl/di/KnockRoom.kt 0.00% 3 Missing :warning:
...eatures/roomlist/impl/components/RoomSummaryRow.kt 95.08% 2 Missing and 1 partial :warning:
...list/impl/datasource/RoomListRoomSummaryFactory.kt 50.00% 1 Missing and 1 partial :warning:
.../android/libraries/matrix/test/FakeMatrixClient.kt 60.00% 2 Missing :warning:
...vite/impl/response/AcceptDeclineInvitePresenter.kt 50.00% 0 Missing and 1 partial :warning:
...ndroid/features/joinroom/impl/JoinRoomPresenter.kt 95.00% 0 Missing and 1 partial :warning:
...ndroid/features/joinroom/impl/di/JoinRoomModule.kt 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3725 +/- ## =========================================== - Coverage 83.02% 83.02% -0.01% =========================================== Files 1752 1753 +1 Lines 43773 43925 +152 Branches 5120 5135 +15 =========================================== + Hits 36344 36469 +125 - Misses 5611 5633 +22 - Partials 1818 1823 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.