Fix oversize padding on captioned images/videos

frebib commented 3 weeks ago

Content

Use consistent padding with the InReplyToView for the media, and consistent caption padding with other textual messages.

Note: The screenshots look kinda broken, but it looks like they were broken before my changes. This renders fine in-app and I've been using this patch for several weeks already.

Motivation and context

It bothered me that the padding around captioned images vs reply blocks was different. Judging by https://github.com/element-hq/element-x-ios/issues/3436 it looks like the behaviour in this PR is more aligned with what iOS does too.

This change does also suffer from the issue outlined in https://github.com/element-hq/element-x-ios/issues/3436 too although I'm not sure that's a new problem.

Screenshots / GIFs

Before	After

Tests

Step 1
Step 2
Step ...

Tested devices

[x] Physical
[ ] Emulator
OS version(s):

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[x] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[x] Pull request is based on the develop branch
[x] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[x] Pull request includes a sign off
[x] You've made a self review of your PR

CLAassistant commented 3 weeks ago

All committers have signed the CLA.

github-actions[bot] commented 3 weeks ago

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

Your branch should be based on origin/develop, at least when it was created.
The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
The test pass locally running ./gradlew test.
The code quality check suite pass locally running ./gradlew runQualityChecks.
If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.04%. Comparing base (870ae5f) to head (012e15e). Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
...s/impl/timeline/components/TimelineItemEventRow.kt	77.77%	2 Missing and 2 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3732 +/- ## =========================================== - Coverage 83.06% 83.04% -0.02% =========================================== Files 1754 1755 +1 Lines 44022 44032 +10 Branches 5144 5148 +4 =========================================== + Hits 36565 36566 +1 - Misses 5635 5638 +3 - Partials 1822 1828 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

frebib commented 2 weeks ago

Nice, thanks Jorge!

element-hq / element-x-android