element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose
GNU Affero General Public License v3.0
1.08k stars 155 forks source link

Incoming session verification #3733

Closed bmarty closed 2 weeks ago

bmarty commented 3 weeks ago

Here is a quick demo of the feature:

https://github.com/user-attachments/assets/58a23b56-4016-4c02-8bd2-d465182bfc8b

github-actions[bot] commented 3 weeks ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HzXNig

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 90.00000% with 62 lines in your changes missing coverage. Please review.

Project coverage is 83.09%. Comparing base (e329370) to head (f03a432). Report is 16 commits behind head on develop.

Files with missing lines Patch % Lines
.../impl/incoming/IncomingVerificationStateMachine.kt 74.28% 16 Missing and 2 partials :warning:
...ion/impl/incoming/IncomingVerificationPresenter.kt 85.71% 5 Missing and 7 partials :warning:
...rifysession/impl/outgoing/VerifySelfSessionView.kt 79.66% 0 Missing and 12 partials :warning:
.../incoming/DefaultIncomingVerificationEntryPoint.kt 0.00% 8 Missing :warning:
...erifysession/api/IncomingVerificationEntryPoint.kt 0.00% 2 Missing :warning:
...atures/verifysession/impl/util/StateMachineUtil.kt 66.66% 2 Missing :warning:
.../verification/SessionVerificationRequestDetails.kt 75.00% 2 Missing :warning:
...est/verification/FakeSessionVerificationService.kt 90.90% 2 Missing :warning:
...ession/impl/outgoing/VerifySelfSessionPresenter.kt 96.77% 0 Missing and 1 partial :warning:
...es/verifysession/impl/ui/VerificationBottomMenu.kt 85.71% 1 Missing :warning:
... and 2 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3733 +/- ## =========================================== + Coverage 83.05% 83.09% +0.04% =========================================== Files 1754 1770 +16 Lines 43994 44378 +384 Branches 5142 5202 +60 =========================================== + Hits 36539 36878 +339 - Misses 5632 5669 +37 - Partials 1823 1831 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud