element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose
GNU Affero General Public License v3.0
1.08k stars 155 forks source link

Target api 35 #3776

Closed bmarty closed 1 week ago

bmarty commented 2 weeks ago

Content

Change compile and target to 35 and fix new warnings in the code. I do not think that we need to take special action for the change about foreground service (see https://developer.android.com/about/versions/15/behavior-changes-15#fgs-hardening). I do not see in https://developer.android.com/about/versions/15/behavior-changes-15 other actions that we should handle.

Also improve code quality on the Versions object.

Motivation and context

Be up to date and allow dependencies to be upgraded (see for instance https://github.com/element-hq/element-x-android/pull/3766)

Screenshots / GIFs

Tests

Tested devices

Checklist

github-actions[bot] commented 2 weeks ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/jxtS3g

sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jmartinesp commented 2 weeks ago

We may have to check:

Changes to language code handling: When using the Locale API, language codes for Hebrew, Yiddish, and Indonesian are no longer converted to their obsolete forms (Hebrew: iw, Yiddish: ji, and Indonesian: in). When specifying the language code for one of these locales, use the codes from ISO 639-1 instead (Hebrew: he, Yiddish: yi, and Indonesian: id).

Could this allow us to remove some localazy post-processing?

Change PendingIntent creators to block background activity launches by default. This helps prevent apps from accidentally creating a PendingIntent that could be abused by malicious actors.

Intents must have actions: Intents without an action will no longer match any intent-filters. This means that intents used to start activities or services must have a clearly defined action.

The last 2 may be closely tied to the Element Call integration.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (fa1e5e5) to head (4f60ee2). Report is 46 commits behind head on develop.

Files with missing lines Patch % Lines
...android/features/share/impl/DefaultShareService.kt 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3776 +/- ## ======================================== Coverage 82.97% 82.97% ======================================== Files 1770 1770 Lines 44422 44422 Branches 5222 5223 +1 ======================================== Hits 36858 36858 Misses 5729 5729 Partials 1835 1835 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.