Fix the onboarding flow getting stuck in some cases

jmartinesp commented 2 weeks ago

Content

DefaultFtueService has now been marked as s singleton.

Motivation and context

This was caused by several DefaultFtueService instances being created and only the latest one receiving new state updates while the LoggedInFlowNode which decides the navigation was stuck subscribed to the initial one.

Screenshots / GIFs

Tests

It's kind of difficult to reproduce the issue, but originally it was done by disabling notifications, which triggered the onboarding 'enable notifications' screen to appear and tapping on either 'enable' or 'not now' did nothing.

Tested devices

[x] Physical
[ ] Emulator
OS version(s): 14

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[x] Pull request is based on the develop branch
[x] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[x] You've made a self review of your PR

github-actions[bot] commented 2 weeks ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/vxckHN

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.97%. Comparing base (fa1e5e5) to head (5cdcd9c). Report is 22 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3778 +/- ## ======================================== Coverage 82.97% 82.97% ======================================== Files 1770 1770 Lines 44422 44422 Branches 5222 5222 ======================================== Hits 36858 36858 Misses 5729 5729 Partials 1835 1835 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

element-hq / element-x-android