Remove all GPS metadata from images uploaded as media

jmartinesp commented 2 weeks ago

Content

Removes all GPS related EXIF metadata from images sent as media (images sent as files will be kept as they are).

Motivation and context

Previously a minimal set of tags were removed, but we should make sure every single one of them is removed.

Tests

Get an image with GPS metadata (you can download one of these).
Send it as media in a room with 'photo & video library' option.
Download the file and pass it through an EXIF metadata viewer, it should have no GPS info.

Maybe do the same while taking a picture using the camera.

Tested devices

[x] Physical
[ ] Emulator
OS version(s): 14

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[x] Pull request is based on the develop branch
[x] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[x] You've made a self review of your PR

github-actions[bot] commented 2 weeks ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/WH3JKF

sonarcloud[bot] commented 2 weeks ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.95%. Comparing base (057ef38) to head (8fb0784). Report is 16 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3781 +/- ## =========================================== + Coverage 82.93% 82.95% +0.01% =========================================== Files 1771 1771 Lines 44483 44514 +31 Branches 5222 5222 =========================================== + Hits 36894 36925 +31 Misses 5754 5754 Partials 1835 1835 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

everypizza1 commented 2 weeks ago

I think that this should be behind a toggle, because sometimes I want to send an image to someone with location data.

jmartinesp commented 1 week ago

I think that this should be behind a toggle, because sometimes I want to send an image to someone with location data.

You can still send the image as a file and it'll be sent with no changes.

element-hq / element-x-android