Create room : improve handling of room address

ganfra commented 3 days ago

Content

This PR improves the room address field management :

Add some validation (check format validity and availability)
Branch the autofill using the name

Motivation and context

Closes https://github.com/element-hq/element-x-android/issues/3866 Closes https://github.com/element-hq/element-x-android/issues/3867

Screenshots / GIFs

Check recorded screenshots for new states.

Tests

Open create room flow
Add a name
Set visibility to public
Play with the address and name fields

Tested devices

[ ] Physical
[ ] Emulator
OS version(s):

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[ ] Pull request is based on the develop branch
[ ] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR

github-actions[bot] commented 3 days ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/6hkKxE

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 89.36170% with 10 lines in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (5c354ba) to head (0a223c3). Report is 4 commits behind head on develop.

Files with missing lines	Patch %	Lines
...eroom/impl/configureroom/ConfigureRoomPresenter.kt	78.12%	3 Missing and 4 partials :warning:
...id/features/createroom/impl/CreateRoomDataStore.kt	75.00%	2 Missing :warning:
...reateroom/impl/configureroom/ConfigureRoomState.kt	66.66%	0 Missing and 1 partial :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3868 +/- ## =========================================== + Coverage 82.84% 82.87% +0.02% =========================================== Files 1783 1784 +1 Lines 45014 45090 +76 Branches 5312 5324 +12 =========================================== + Hits 37293 37368 +75 + Misses 5861 5857 -4 - Partials 1860 1865 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.