Fix unified push unregister

element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose

GNU Affero General Public License v3.0

1.08k stars 155 forks source link

Fix unified push unregister #3877

Closed bmarty closed 1 day ago

bmarty commented 1 day ago

Content

There was 2 user stories where the UnifiedPush subject was not properly removed:

it the user chooses to switch the the Firebase push provider
when the user logs out and is using UnifiedPush

The video below shows that after those 2 use cases, the ntfy app shows an empty list of topics. This was not the case before.

Motivation and context

Cleanup data and avoid ghost subscribed topic.

Screenshots / GIFs

https://github.com/user-attachments/assets/88cc821a-f9dc-4e52-9673-4d076fb28cf1

Tests

Repeat the steps from the video above.

Tested devices

[ ] Physical
[x] Emulator
OS version(s):

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[ ] Pull request is based on the develop branch
[ ] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR

github-actions[bot] commented 1 day ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/equB5n

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (5d8d399) to head (f0aca00). Report is 15 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../android/libraries/push/impl/DefaultPushService.kt	87.50%	0 Missing and 2 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3877 +/- ## =========================================== + Coverage 82.87% 82.90% +0.02% =========================================== Files 1784 1784 Lines 45090 45095 +5 Branches 5324 5326 +2 =========================================== + Hits 37369 37386 +17 + Misses 5857 5843 -14 - Partials 1864 1866 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 day ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud