fix : use RoomMembershipObserver to close room screen when leaving

element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose

GNU Affero General Public License v3.0

1.09k stars 156 forks source link

fix : use RoomMembershipObserver to close room screen when leaving #3887

Closed ganfra closed 17 hours ago

ganfra commented 4 days ago

Content

Close the room flow when leaving a room from the client. If leaving, being banned from another client, the room screen will update but won't navigate up to the room list.

Motivation and context

Screenshots / GIFs

No ui change.

Tests

Step 1
Step 2
Step ...

Tested devices

[ ] Physical
[ ] Emulator
OS version(s):

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[ ] Pull request is based on the develop branch
[ ] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR

github-actions[bot] commented 4 days ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/g3dQCC

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.85%. Comparing base (86a6244) to head (aa1a151). Report is 83 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3887 +/- ## =========================================== - Coverage 82.87% 82.85% -0.02% =========================================== Files 1784 1784 Lines 45090 45088 -2 Branches 5324 5323 -1 =========================================== - Hits 37368 37358 -10 - Misses 5857 5865 +8 Partials 1865 1865 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

sonarcloud[bot] commented 1 day ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud