Min size for hidden media

element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose

GNU Affero General Public License v3.0

1.09k stars 156 forks source link

Min size for hidden media #3906

Closed bmarty closed 1 day ago

bmarty commented 2 days ago

Content

First commit: ensure that media cannot be opened full screen when it is hidden. It has to be revealed first. Second commit: Ensure that when a media is hidden, the "Show" button is always visible in case the aspect ratio is very low or very high.

Motivation and context

Closes #3865

Screenshots / GIFs

Before	After	After, media shown

Tests

Step 1
Step 2
Step ...

Tested devices

[ ] Physical
[x] Emulator
OS version(s):

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[ ] Pull request is based on the develop branch
[ ] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR

github-actions[bot] commented 2 days ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pKWVso

sonarcloud[bot] commented 1 day ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.94%. Comparing base (7edfefe) to head (aa1948a). Report is 34 commits behind head on develop.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3906 +/- ## =========================================== + Coverage 82.91% 82.94% +0.03% =========================================== Files 1785 1787 +2 Lines 45164 45178 +14 Branches 5332 5335 +3 =========================================== + Hits 37446 37474 +28 + Misses 5847 5827 -20 - Partials 1871 1877 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles