change : confirm biometric before allowing biometric unlock.

ganfra commented 4 days ago

Content

Before allowing to unlock the app with biometric, user should now confirm his biometric. Also added a bunch of tests regarding biometric.

Motivation and context

Closes https://github.com/element-hq/customer-success/issues/399

Screenshots / GIFs

No ui changes as the bottomsheet for biometric is handled by the system.

Tests

Step 1
Step 2
Step ...

Tested devices

[ ] Physical
[ ] Emulator
OS version(s):

Checklist

[ ] Changes have been tested on an Android device or Android emulator with API 23
[ ] UI change has been tested on both light and dark themes
[ ] Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
[ ] Pull request is based on the develop branch
[ ] Pull request title will be used in the release note, it clearly define what will change for the user
[ ] Pull request includes screenshots or videos if containing UI changes
[ ] Pull request includes a sign off
[ ] You've made a self review of your PR

github-actions[bot] commented 4 days ago

:iphone: Scan the QR code below to install the build (arm64 only) for this PR. QR code If you can't scan the QR code you can install the build via this link: https://i.diawi.com/zyha13

sonarcloud[bot] commented 4 days ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 30.18868% with 37 lines in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (e76f7fb) to head (2b75fff). Report is 18 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../biometric/DefaultBiometricAuthenticatorManager.kt	0.00%	18 Missing :warning:
...ockscreen/impl/biometric/BiometricAuthenticator.kt	0.00%	16 Missing :warning:
...n/impl/biometric/DefaultBiometricUnlockCallback.kt	33.33%	2 Missing :warning:
...atures/lockscreen/impl/DefaultLockScreenService.kt	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #3930 +/- ## =========================================== - Coverage 82.98% 82.97% -0.02% =========================================== Files 1788 1788 Lines 45208 45221 +13 Branches 5334 5335 +1 =========================================== + Hits 37516 37520 +4 - Misses 5818 5828 +10 + Partials 1874 1873 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

element-hq / element-x-android