element-hq / element-x-android

Android Matrix messenger application using the Matrix Rust Sdk and Jetpack Compose
Apache License 2.0
886 stars 115 forks source link

Chat bubbles from sender in undifferentiated color #937

Closed kongo09 closed 8 months ago

kongo09 commented 11 months ago

Your use case

What would you like to do?

Writing a chat message, I see a bubble right-aligned after clicking send. Typically, such a sender bubble comes in a different color from the receiving bubbles. The color seems different, but only a shade of grey.

Why would you like to do it?

How would you like to achieve it?

Use the brand color like other messengers do

Have you considered any alternatives?

No response

Additional context

No response

Are you willing to provide a PR?

No

kongo09 commented 11 months ago

Screenshot_20230720-163252

du82 commented 11 months ago

I think it should be like Signal wjere you can customize it per-chat

Screenshot_2023-07-22-09-40-06-91_4b14b257287ac0a6d1fd5fbb2487716f

bmarty commented 11 months ago

The color we are using right now are defined here: https://github.com/vector-im/element-x-android/blob/develop/libraries/designsystem/src/main/kotlin/io/element/android/libraries/designsystem/theme/ColorAliases.kt#L48:

// This color is not present in Semantic color, so put hard-coded value for now
val SemanticColors.messageFromMeBackground
    get() = if (isLight) {
        // We want LightDesignTokens.colorGray400
        Color(0xFFE1E6EC)
    } else {
        // We want DarkDesignTokens.colorGray500
        Color(0xFF323539)
    }

// This color is not present in Semantic color, so put hard-coded value for now
val SemanticColors.messageFromOtherBackground
    get() = if (isLight) {
        // We want LightDesignTokens.colorGray300
        Color(0xFFF0F2F5)
    } else {
        // We want DarkDesignTokens.colorGray400
        Color(0xFF26282D)
    }

Pinging the design team to have a status about the values.

leeashlee commented 10 months ago

What's the status of this issue?

kongo09 commented 10 months ago

I think a colour picker is not top prio. The colour should instead reflect the brand as it does with other messengers

du82 commented 10 months ago

I think a colour picker is not top prio. The colour should instead reflect the brand as it does with other messengers

You should never put branding over user customization. Users dont care about the brand

kongo09 commented 10 months ago

Users dont care about the brand

Can you backup your statement with any scientific research?

callumu commented 8 months ago

We have a plan to create clearer distinction between message bubbles of the sender and receiver in the future