element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
426 stars 105 forks source link

Missing events received before accepting room invite #1240

Closed germain-gg closed 4 months ago

germain-gg commented 1 year ago

Steps to reproduce

  1. Alice creates an e2ee room
  2. Alice sends three messages
  3. Bob accepts the invite
  4. Alice sends another message

Outcome

What did you expect?

For Bob to see four messages

What happened instead?

Bob only saw the last message that Alice sent, the one sent after he accepted the room invite

Your phone model

iPhone 13

Operating system version

iOS 16

Application version

1.1.6 (267)

Homeserver

matrix.org

Will you send logs?

Yes

pixlwave commented 1 year ago

Issue for this is in the SDK here: https://github.com/matrix-org/matrix-rust-sdk/issues/2302

ara4n commented 1 year ago

this just bit me really badly; it's a horrible flaky bug.

ara4n commented 1 year ago

worse, it looks like everything you then send into the newly joined room is UTD

ara4n commented 1 year ago

To add insult to injury, it briefly flashes up the messages in the timeline before then hiding them again on accepting an invite. There's also some other pattern happening where they sometimes reappear on launch, but sometimes don't.

Hywan commented 1 year ago

Just tested and things are fixed.

ara4n commented 6 months ago

unsure - just saw a report of this in the wild:

image

9p4 commented 6 months ago

I'm the user in the screenshot above.

Let me know if you need any more information.

Hywan commented 5 months ago

Just tested again and it works:

Screenshot from mnt_io point of view:

C74F4A91-0292-44DC-9713-8CF695841018

Tested with Element X iOS 1.6.8 (601). If it doesn't work, I would suspect the proxy to have some lags or something like that.

stefanceriu commented 4 months ago

Ivan is right, this is no longer an issue.

ara4n commented 4 months ago

i am very sure this is still an issue - i saw it happen on amandine's account last week. we just don't have the right repro steps yet. let's continue this at https://github.com/element-hq/element-x-ios/issues/2024