search

element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
422 stars 100 forks source link

Autocorrect on macOS breaks input #1786

Open domoritz opened 1 year ago

domoritz commented 1 year ago

Steps to reproduce

I use element X on macOS (Mac with apple silicon) on Sonoma. Try typing a longer message.

Outcome

I noticed that whenever I encounter a place where the OS auto-completes a word, the beginning of the word gets removed. This is pretty common and definitely easy to reproduce with any sentence. However, I found that if I type the same word again, the message doesn't break.

Your phone model

macBook pro

Operating system version

macOS Sonoma

Application version

1.3.0 (72)

Homeserver

No response

Will you send logs?

No

domoritz commented 11 months ago

I don't think this is occasional. For me this happens in almost every single message so that Element X is pretty much useless on Mac. I use Element X on my phone exclusively but on Mac I always use Element because of this bug.

pixlwave commented 11 months ago

In this instance, occasional refers to the fact that the overwhelming majority of our users are on iPhone rather than Mac.

Kimiblock commented 11 months ago

Somehow the iOS version breaks Chinese (probably CJK) input.

Slide to type can reliably reproduce this feature.

domoritz commented 8 months ago

I think this issue is also happening on iOS where if I do a backspace when a recommendations shown, element X keeps the recommendation after the cursor.

manuroe commented 8 months ago

Duplicate of https://github.com/element-hq/element-x-ios/issues/2491

domoritz commented 8 months ago

It's probably the same underlying bug and since the other issue is marked as higher severity/frequency it makes sense to dupe.

stefanceriu commented 5 months ago

Reopening this as per https://github.com/element-hq/element-x-ios/issues/2491#issuecomment-2143197811

Velin92 commented 3 months ago

fixed on the latest version

domoritz commented 3 months ago

In 1.6.13?

Velin92 commented 3 months ago

it's on develop, so it will be available in the next release

domoritz commented 3 months ago

I have 1.7.1 (117) and autocomplete is still broken on macOS. Can you confirm the version this is fixed in?

Velin92 commented 3 months ago

yes it should contain the fix for iOS, maybe the issue is still persisting on mac, do you mind showing it to us on 1.7.1?

domoritz commented 3 months ago

Thanks for looking into this. This is on the latest versions:

https://github.com/user-attachments/assets/db04f344-cdec-4731-966b-06ddfc84861b

domoritz commented 2 months ago

@Velin92 can you reopen the issue?

Velin92 commented 2 months ago

Okay I see, the issue is not in the RTE, but on the plain composer. In the meantime the issue should be fixed if you enable the formatting toolbar which will use the rich text editor composer, we will investigate what is wrong with the plain text one.

josephnoir commented 2 months ago

It happens for me in both composers. Using macOS 14.6.1 and Element X Version 1.7.3 (119).

https://github.com/user-attachments/assets/02b28b2a-db1b-493d-8e70-258a0200bdd6

Edit: I'm not sure if that is relevant, but I have multiple Input Sources enabled: German, 2-Set Korean, and U.S.