element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
401 stars 88 forks source link

Edits sometimes show original msg, not edited msg. #2252

Open ara4n opened 9 months ago

ara4n commented 9 months ago

Steps to reproduce

  1. Send a message on another client (EW in this case)
  2. Someone reacts to it (this may or may not be important)
  3. Edit your msg
  4. More reactions happen

Later, view the msg in scrollback on EX. It’s shown as edited, but the contents shows the pre-edited contents, not the edited content! 🙀

concretely:

image

is a msg i sent, and then fixed the thinko of “go” to “typescript”. but the edit doesn’t show up.

Outcome

What did you expect?

reliable edits

What happened instead?

flakey timeline code.

Your phone model

No response

Operating system version

No response

Application version

463

Homeserver

No response

Will you send logs?

Yes

ara4n commented 9 months ago

rageshake is down so i can't submit logs. https://matrix.to/#/!IIDRCwzJTNnOmMxacp%3Amatrix.org/%24BkoaVoIn-FFKS64JNoVQUiJuF7e_IG0J1wB-Z41A7BQ is the msg in q

ara4n commented 8 months ago

it often seems to flip back and forth - i just saw it flap between the edited and non edited version in the timeline about 3 times after having sent the edit...

ara4n commented 8 months ago

see also https://github.com/element-hq/element-x-ios/issues/1895

stefanceriu commented 3 months ago

Still 100% reproducible (reactions don't matter). They fix themselves after re-entering the room after having loaded them once and then break again when clearing out the cache.

stefanceriu commented 3 months ago

Already reported on the RustSDK under https://github.com/matrix-org/matrix-rust-sdk/issues/3492

manuroe commented 3 months ago

@Hywan could this be fixed by the event cache storage?

manuroe commented 2 months ago

@Hywan could this be fixed by the event cache storage?

it is not.

ara4n commented 3 weeks ago

still getting it on build 690