search

element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
435 stars 106 forks source link

RRs are missing when a state event is the latest displayed event, causing them to disappear #2338

Open Velin92 opened 10 months ago

Velin92 commented 10 months ago

Steps to reproduce

  1. Enter a room
  2. Check RRs for the last message
  3. Now have a state event be sent to the room that is displayed to all the users
  4. Have other users see that state event

Outcome

What did you expect?

The RRs should be displayed on the state event

What happened instead?

RRs are not displayed, so they end up disappearing when moving from a message to the state event

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

Velin92 commented 10 months ago

@VolkerJunginger should we actually display RRs for state events? Web does that and also Android, however this means that if we hide some of the state events in the future we lose RRs in the timeline

Velin92 commented 10 months ago

This could solve the issue: https://github.com/matrix-org/matrix-rust-sdk/issues/3065

giomfo commented 9 months ago

reproduced on v1.5.9(527)

manuroe commented 4 months ago

If the RR is on a state event at the protocol level, we want to display it on the closest previous message in the timeline as described in https://github.com/matrix-org/matrix-rust-sdk/issues/3065.

We will update EXA once it is available. cc @element-hq/element-android .