Edits aren’t reflected in room's latest visible event

ara4n commented 5 months ago

Steps to reproduce

Send a message to a room
Fix a typo in it
Go to room list
Stare at the typo in the room preview, which never updates
Feel like the app is completely flakey: did it not send my edit? or are room previews unreliable?

Outcome

What did you expect?

reliable room previews.

We should reflect the last visible message, including edits.

That means:

We don’t show edit events themselves (as they be out of order - ie editing an older msg; and fallbacks are ugly)
The preview should show the most recent visible msg in a room including incorporating any edits.

What happened instead?

in trying to avoid putting ugly “* foo” edited msgs in room previews, we threw away upholding edits entirely :(

Your phone model

No response

Operating system version

No response

Application version

570

Homeserver

No response

Will you send logs?

No

stefanceriu commented 5 months ago

This is implemented as requested in https://github.com/element-hq/element-meta/issues/2301

ara4n commented 5 months ago

the current behaviour is very clearly a bug, even if the meta bug says that it's acceptable.

VolkerJunginger commented 5 months ago

The "implementation" in https://github.com/element-hq/element-meta/issues/2301 was made (to my understanding) to stop showing the "wrong" messages in the room-list when editing messages.

The behaviour was that any message that was edited last was shown as last message so the preview would show an older message instead of the last message in a room.

So this bug is valid as we should show the edited version of the LAST message (only) one day.

element-hq / element-x-ios