search

element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
419 stars 98 forks source link

Support for the `max_selections` poll parameter #2756

Open jkhsjdhjs opened 5 months ago

jkhsjdhjs commented 5 months ago

Is your feature request related to a problem? Please describe. It is currently not possible to select multiple options on a poll.

Describe the solution you'd like It should be possible to select multiple options if max_selections allows for it. Selecting another option shouldn't unselect previously selected options. Instead, selected options may be unselected by tapping them again.

Additional context See also: https://github.com/element-hq/element-web/issues/23319

nitn3lav commented 2 weeks ago

This was already implemented for Element Web. However, the PR https://github.com/matrix-org/matrix-react-sdk/pull/9519 was rejected because it wouldn't be cross platform across all versions of Element. I would be happy to implement this for iOS (both Element X and Element) and I might also take a look at Android. Could you please confirm that this would get merged (if code meets all requirements, etc.)

CC: @dbkr

stefanceriu commented 2 weeks ago

Could you please confirm that this would get merged

This is not the right place to ask that question. You should raise a ticket on https://github.com/element-hq/element-meta/issues and have somebody from the products team answer it.

Otherwise, I'm more than happy to look at the underlying implementation and merge it without enabling any changes on the UI level. (mind you, most of this logic should be on the rust side for EX)