search

element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
409 stars 94 forks source link

Use a Client in AuthenticationService now that the Rust one has been removed. #2954

Closed pixlwave closed 3 months ago

pixlwave commented 3 months ago

Rust's AuthenticationService has been removed in https://github.com/matrix-org/matrix-rust-sdk/pull/3594. This PR moves what was very simple logic that called into a Client directly into our app-side AuthenticationService.

Can be reviewed commit-by-commit.

github-actions[bot] commented 3 months ago
Warnings
:warning: Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by :no_entry_sign: Danger Swift against e38d5d46c0d026f334d98b266d62d1655a6efc4c

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 1.06383% with 93 lines in your changes missing coverage. Please review.

Project coverage is 78.23%. Comparing base (fc0573a) to head (e38d5d4).

Files Patch % Lines
...ervices/Authentication/AuthenticationService.swift 0.00% 38 Missing :warning:
...mentX/Sources/Other/Extensions/ClientBuilder.swift 0.00% 20 Missing :warning:
ElementX/Sources/Application/AppCoordinator.swift 0.00% 9 Missing :warning:
...X/Sources/Services/QRCode/QRCodeLoginService.swift 0.00% 8 Missing :warning:
...s/Authentication/OIDCAuthenticationPresenter.swift 0.00% 6 Missing :warning:
...ources/Services/UserSession/UserSessionStore.swift 0.00% 4 Missing :warning:
NSE/Sources/Other/NSEUserSession.swift 0.00% 4 Missing :warning:
...ntication/LoginScreen/LoginScreenCoordinator.swift 0.00% 1 Missing :warning:
...ctionScreen/ServerSelectionScreenCoordinator.swift 0.00% 1 Missing :warning:
...SoftLogoutScreen/SoftLogoutScreenCoordinator.swift 0.00% 1 Missing :warning:
... and 1 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2954 +/- ## =========================================== - Coverage 78.45% 78.23% -0.22% =========================================== Files 691 694 +3 Lines 54047 54172 +125 =========================================== - Hits 42405 42384 -21 - Misses 11642 11788 +146 ``` | [Flag](https://app.codecov.io/gh/element-hq/element-x-ios/pull/2954/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/element-hq/element-x-ios/pull/2954/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `68.82% <1.06%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.