search

element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
409 stars 94 forks source link

Joining a room you don't have permission to join gives an ugly error #2961

Closed ara4n closed 2 months ago

ara4n commented 3 months ago

Steps to reproduce

  1. Click on a permalink to a private room you're not invited to
  2. Observe generic "error occurred" error msg.

Outcome

What did you expect?

Nice error message

What happened instead?

Ugly error msg

Your phone model

No response

Operating system version

No response

Application version

628

Homeserver

No response

Will you send logs?

No

manuroe commented 3 months ago

We need to synchronise what Android is doing in this case.

bmarty commented 3 months ago

This is how clicking on a link to an other account private room renders on EXA:

image

and the code to get in this state: https://github.com/element-hq/element-x-android/blob/develop/features/joinroom/impl/src/main/kotlin/io/element/android/features/joinroom/impl/JoinRoomPresenter.kt#L105

And the Figma: https://www.figma.com/design/Ni6Ii8YKtmXCKYNE90cC67/Timeline-(new)?node-id=570-35734&t=rdrljKGGGM6OkvD6-0

image