element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
409 stars 94 forks source link

Cleanup how we setup the CallKit provider and have it be used for outgoing calls as well #2967

Closed stefanceriu closed 3 months ago

stefanceriu commented 3 months ago

…going calls as well

github-actions[bot] commented 3 months ago
Warnings
:warning: Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
:warning: You seem to have made changes to views. Please consider adding screenshots.

Generated by :no_entry_sign: Danger Swift against c2461f422547ed60583197d3beb5bcf453b94c91

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 5.26316% with 108 lines in your changes missing coverage. Please review.

Project coverage is 77.90%. Comparing base (fa22b98) to head (c2461f4). Report is 3 commits behind head on develop.

Files Patch % Lines
...rces/Services/ElementCall/ElementCallService.swift 0.00% 86 Missing :warning:
.../FlowCoordinators/UserSessionFlowCoordinator.swift 26.31% 14 Missing :warning:
...urces/Screens/CallScreen/CallScreenViewModel.swift 0.00% 4 Missing :warning:
ElementX/Sources/Application/AppCoordinator.swift 0.00% 3 Missing :warning:
...X/Sources/Screens/CallScreen/View/CallScreen.swift 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2967 +/- ## =========================================== - Coverage 78.02% 77.90% -0.12% =========================================== Files 693 693 Lines 54172 54281 +109 =========================================== + Hits 42269 42290 +21 - Misses 11903 11991 +88 ``` | [Flag](https://app.codecov.io/gh/element-hq/element-x-ios/pull/2967/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/element-hq/element-x-ios/pull/2967/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `68.77% <5.26%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud