search

element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
426 stars 103 forks source link

Blank People Filter #2970

Closed neilisfragile closed 4 months ago

neilisfragile commented 4 months ago

Steps to reproduce

  1. Where are you starting? What can you see? Start from the room list

  2. What do you click? Click on the 'People' tab

Outcome

What did you expect?

To see a list of my DMs

What happened instead?

I see an empty screen, that tells me I do not have any DMs

I rage shook in the past here but it has never worked for me.

I can see other examples that seem to be the same thing here and here There are also some examples in the EXA rageshake repo as well, here and here

Your phone model

No response

Operating system version

No response

Application version

No response

Homeserver

matrix.org

Will you send logs?

Yes

Velin92 commented 4 months ago

What version of the app are you using? We are aware that we had this issue in the past but it should be fixed for a while, in fact I see the rageshakes reporting 1.5.12 as the version of the issue, but the latest released version is 1.6.11

neilisfragile commented 4 months ago

I'm currently using the 1.6.13 (633) nightly. To my knowledge it has never worked for me - though potentially this could be related to being an early adopter. Would it be helpful to log out and in again (I'm mindful this could destroy useful investigative data)?

Could it be the case that it is fixed for new log-ins after the fix?

Neil

On Thu, Jun 27, 2024 at 1:11 AM Mauro @.***> wrote:

What version of the app are you using? We are aware that we had this issue in the past but it should be fixed for a while, in fact I see the rageshakes reporting 1.5.12 as the version of the issue, but the latest released version is 1.6.11

— Reply to this email directly, view it on GitHub https://github.com/element-hq/element-x-ios/issues/2970#issuecomment-2192822471, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADODWBUYOBZVK5Z2YLNZTDZJNKEZAVCNFSM6AAAAABJ6J7OXKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSHAZDENBXGE . You are receiving this because you authored the thread.Message ID: @.***>

--

Copyright © 2024 Element - All rights reserved. The Element name, logo and device are registered trademarks of New Vector Ltd. Registered number:

  1. Registered in England and Wales. Registered address: 10 Queen Street Place, London, United Kingdom, EC4R 1AG.

This message is intended for the addressee only and may contain private and confidential information or material which may be privileged. If this message has come to you in error please delete it immediately and do not copy it or show it to any other person.

Velin92 commented 4 months ago

You could try that yeah... however since you say you are an early adopter may you check also, maybe through web if your DMs are actually marked with the isDirect flag, are encrypted and only ever contained 2 joined people, we consider a DM in El-X a room that always had 2 joined members at any time, is direct and encrypted.

neilisfragile commented 4 months ago

I definitely have plenty of m.direct, 2 person, encrypted rooms so that doesn't seem to be the problem.

Velin92 commented 4 months ago

Okay I see, so I imagine DMs also appear with the DM UI as expected right, for example the avatar in the detail view should appear with your avatar overlapped with the other person's avatar:

Screenshot 2024-06-27 at 18 21 19

Because I want to understand if at least the SDK models and the app "understand" that a specific room is a DM, and so if is just a filter issue, or for some reason the room is not recognised as a DM.

Also maybe would be worth sending another rageshake, because as I said, we had an issue that has broken the People filter for everyone some time ago, but has been recently fixed, and if there are still some cases where this issue happens we should double check it with the latest logs.

neilisfragile commented 4 months ago

https://github.com/element-hq/element-x-ios-rageshakes/issues/1929

neilisfragile commented 4 months ago

I can't find anywhere in the app where I have the overlapping avatars - that sounds significant.

When I look at a DM and click on the top bar I go to a 'Room Info' screen - I'm wondering if the name is a give away that it is treated as a room rather than DM.

Velin92 commented 4 months ago

Interesting I have seen this from the logs: 2024-06-27T16:06:35.409139Z WARN matrix_sdk_base::client: Failed to deserialize a global account data event: leading sigil is incorrect or missing at line 1 column 3432 event_type="m.direct" | crates/matrix-sdk-base/src/client.rs:630 | spans: root > sync_once > handle_response > handle_account_data

Seems that there is something in the account data m.direct field that is not recognised properly, maybe you have a userin your dm list, which has an incorrect matrix username?

Because this is probably preventing the app to interpret which rooms are direct properly and is making all your rooms being considered as normal non direct rooms.

Velin92 commented 4 months ago

Closing the issue due to being an account data issue.

yostyle commented 1 week ago

Probably related to https://github.com/element-hq/element-x-ios/issues/3489

If you create a DM by invite a user by email, the m.direct contains this email and the DM room list is empty on Element X.