element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
Apache License 2.0
365 stars 75 forks source link

Use local room list sorting from Rust. #2978

Closed stefanceriu closed 41 minutes ago

stefanceriu commented 1 week ago
github-actions[bot] commented 1 week ago
Warnings
:warning: Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
:warning: You seem to have made changes to views. Please consider adding screenshots.

Generated by :no_entry_sign: Danger Swift against 507e9511a1f274032b5a63c416cf4d51ffe660fd

sonarcloud[bot] commented 16 hours ago

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 15 hours ago

Codecov Report

Attention: Patch coverage is 77.77778% with 46 lines in your changes missing coverage. Please review.

Project coverage is 77.80%. Comparing base (c024702) to head (507e951).

Files Patch % Lines
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% 46 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2978 +/- ## =========================================== - Coverage 77.92% 77.80% -0.12% =========================================== Files 694 695 +1 Lines 53939 53847 -92 =========================================== - Hits 42032 41897 -135 - Misses 11907 11950 +43 ``` | [Flag](https://app.codecov.io/gh/element-hq/element-x-ios/pull/2978/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/element-hq/element-x-ios/pull/2978/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `68.62% <77.77%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.