search

element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
Apache License 2.0
365 stars 75 forks source link

Remove layout styling abstraction #2982

Closed Velin92 closed 1 week ago

sonarcloud[bot] commented 1 week ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions[bot] commented 1 week ago
Warnings
:warning: Please provide a description for this PR.
:warning: Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
:warning: You seem to have made changes to views. Please consider adding screenshots.

Generated by :no_entry_sign: Danger Swift against 36a883c48840fbd08d1496bd825ad7182ef81a20

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 89.65517% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (064b1bf) to head (36a883c).

Files Patch % Lines
...omScreen/View/Timeline/EmoteRoomTimelineView.swift 50.00% 1 Missing :warning:
...mScreen/View/Timeline/NoticeRoomTimelineView.swift 50.00% 1 Missing :warning:
...ngs/SettingsScreen/SettingsScreenCoordinator.swift 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2982 +/- ## =========================================== + Coverage 77.45% 77.46% +0.01% =========================================== Files 693 693 Lines 54101 54037 -64 =========================================== - Hits 41902 41860 -42 + Misses 12199 12177 -22 ``` | [Flag](https://app.codecov.io/gh/element-hq/element-x-ios/pull/2982/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/element-hq/element-x-ios/pull/2982/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `68.48% <89.65%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.