search

element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
Apache License 2.0
365 stars 75 forks source link

Add support for editing local echoes and remove redundant failed sent message menu #2983

Closed stefanceriu closed 6 days ago

github-actions[bot] commented 6 days ago
Warnings
:warning: Please provide a description for this PR.
:warning: Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
:warning: You seem to have made changes to views. Please consider adding screenshots.

Generated by :no_entry_sign: Danger Swift against f5957028e0dea859547170450e3d47eefcc3c2b4

github-actions[bot] commented 6 days ago
Warnings
:warning: Please provide a description for this PR.
:warning: Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
:warning: You seem to have made changes to views. Please consider adding screenshots.

Generated by :no_entry_sign: Danger Swift against f5957028e0dea859547170450e3d47eefcc3c2b4

sonarcloud[bot] commented 6 days ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.99%. Comparing base (3cc4145) to head (f595702).

Files Patch % Lines
...een/View/Style/TimelineItemBubbledStylerView.swift 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #2983 +/- ## =========================================== + Coverage 77.86% 77.99% +0.13% =========================================== Files 693 693 Lines 53792 53770 -22 =========================================== + Hits 41884 41940 +56 + Misses 11908 11830 -78 ``` | [Flag](https://app.codecov.io/gh/element-hq/element-x-ios/pull/2983/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/element-hq/element-x-ios/pull/2983/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq) | `68.59% <50.00%> (+0.09%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=element-hq#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.