search

element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
400 stars 87 forks source link

SSS: Spurious idle rooms keep surfacing in the roomlist #3096

Open ara4n opened 1 month ago

ara4n commented 1 month ago

Steps to reproduce

  1. Enable SSS on a largeish account
  2. Giggle happily as it syncs roughly as fast as with SS and the proxy
  3. Observe that some random idle room keeps bubbling up near the top of the room list for no obvious reason (!NNtfYnugaAKouPTJdp:matrix.org aka Element Demo in this instance):

IMG_7854

Outcome

What did you expect?

Element Demo should be buried many many pages down the roomlist as there haven’t been any events there for weeks.

What happened instead?

IMG_7855

Your phone model

No response

Operating system version

No response

Application version

663

Homeserver

No response

Will you send logs?

Yes

ara4n commented 1 month ago

(also, note the timestamp on the conduit room room preview is wonky; looks like the subscribe failed)

manuroe commented 1 month ago

Probably an issue with with the bumpstamp. Likely a backend issue. @erikjohnston can you check the rageshake?

erikjohnston commented 1 month ago

That room has a bot that sends a m.notice very frequently. Looks like the SDK is desperately trying to paginate back to find a normal message.

My guess is that the rust SDK is not handling that situation particularly well, and TBH I'm not sure what the best way to handle that situation is (i.e. where its broadly impossible to find a bump event).

FTR the room ID is !NNtfYnugaAKouPTJdp:matrix.org. Searching in the rageshake you can clearly see repeated attempts to backpaginate.

Hywan commented 1 month ago

The SDK doesn't backpaginate a room automatically. It happens only when the timeline is scrolling to the top as far as I know. cc @bnjbvr can you confirm?

(cc https://github.com/matrix-org/matrix-rust-sdk/issues/3647)

bnjbvr commented 1 month ago

Backpagination doesn't happen automatically at the moment, but as far as I recall, the EX apps may automatically backpaginate after a room has been entered.

erikjohnston commented 1 month ago

Huh, I thought I saw the app try and call a lot of /messages, but maybe that was because M had entered the room.

ara4n commented 3 weeks ago

empirically if i enter that room, it spins forever and never loads. shouldn't the m.notices be visible? the room doesn't rise to the surface on other clients iirc.

stefanceriu commented 2 weeks ago

@ara4n Haven't seen this myself, is is still a problem?