element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
399 stars 87 forks source link

Dark mode app icon #3164

Open ara4n opened 1 month ago

ara4n commented 1 month ago

Is your feature request related to a problem? Please describe.

Apparently iOS18 supports dark mode icons. It autogens these when it can, but EX's icon is too complex for it. Therefore we should probably provide our own.

Describe the solution you'd like

Credit to @maddie:spyhoodle.me:

image

On the left you see an autogenned dark-mode classic Element icon. But on the right, there is no dark-mode icon.

Additional context

https://matrix.to/#/!amwlFMejXQcoCxNYHH:matrix.org/$Aj8mBeo2RFbOqkEkwiXb5t2LOK0DUrrThxhcRX3L3p8?via=matrix.org&via=element.io&via=beeper.com

jjj333-p commented 1 month ago

Just adding context, ios 18 also allows coloring them to a theme, and based on how it treats that, I suspect its the gradient. i think if the background gradient was flattened it would be able to generate one on the fly.

image

ProbablyRohan commented 1 month ago

I would love if we were able to change the Element X icon to the one that the old Element app has as well, similar to how you can change the icon in the GitHub app. This would require a bit of extra work though.