search

element-hq / element-x-ios

Next generation Matrix client for iOS built with SwiftUI on top of matrix-rust-sdk.
https://element.io/labs/element-x
GNU Affero General Public License v3.0
431 stars 105 forks source link

Push notifications use wrong avatar #3293

Open marwing opened 2 months ago

marwing commented 2 months ago

Steps to reproduce

  1. Join some rooms
  2. Wait for notification
  3. ???
  4. Notice notification with wrong room avatar as icon

Outcome

IMG_4115

What did you expect?

top

What happened instead?

bottom

Some of these also change to the correct icon after some time (this is the top message with its original wrong one): IMG_4114

Additional Context

I have only noticed this after updating to iOS 18 RC (~a week ago) and only on my session still using the sliding sync proxy (I don't know if it happens with SSS as I'm not using that device much currently).

I have noticed this happening for four rooms so far (#element-x-ios:matrix.org, #matrix-conf-general:matrix.org, #synapse:matrix.org and #foundation-office:matrix.org) but it's always the avatar of #e2e:matrix.org that shows up.

This has persisted over reboots and logouts/logins in the app (with forced proxy).

This is happening relatively frequently. From the notifications I still have in my notification center, I'd say about 10-20% of notifications in the affected rooms exhibit this behavior (factoring in that some of them fix themselves).

Your phone model

iPhone 13 mini

Operating system version

iOS 18.0

Application version

1.8.1 (123)

Homeserver

Synapse 1.114.0 / Proxy 0.99.19

Will you send logs?

Yes

marwing commented 2 months ago

I'm now blaming this on iOS after observing this today, unless someone has a reason to do otherwise. The way the icons fix themselves feels like a notification ui bug on the side of the system instead of the app, especially since it seems to react to my interactions with the notification center.

Feel free to close this when triaging, otherwise I'm probably going to in the next few days after watching this some more.

pixlwave commented 2 months ago

@marwing Thanks for the follow-up. I was wondering if this was the case - I saw the same bug last year when iOS 17 landed and came to the same conclusion. Happy to leave this open whilst you monitor it a bit more though :)

marwing commented 2 months ago

I'm closing this now. Somehow this seems to have stopped happening and I don't see the app having much to do with that. (Even though the SDK and notification updates in 1.8.2 and 1.8.3 may have affected this (specifically https://github.com/element-hq/element-x-ios/pull/3307 maybe)?. The releases were so close together that it's hard to notice what bugs were fixed in each version.) FTR, another device with synapse SSS was also impacted, so this wasn't just SS as in the original report.

lampholder commented 1 month ago

Just wanted to note that I saw this today on Element Nightly.

manuroe commented 1 month ago

It started to happen a lot to me in last few days. Same config as Tom.

marwing commented 1 month ago

If this is reopened, I may as well mention that this never really stopped for me. I noticed it again a few days after my closing comment but didn't bother updating this issue (since I closed it with the conclusion it probably wasn't this app's fault).

Hywan commented 3 weeks ago

I'm also noticing this since today. First time it happens. Feels weird :-/.

morguldir commented 2 weeks ago

Seeing it happen a lot with snapchat too, sometimes it even uses icons that are from Element X

Hywan commented 2 weeks ago

Okay, so definitely a bug from the OS, damn…

ara4n commented 1 week ago

I've been getting it a lot in the last week or so, as has Amandine.

I wonder if there's a workaround we can do to kick a cache somewhere, e.g. using a different filename for each image on the notif UI or something?