search

element-hq / hydrogen-web

Lightweight matrix client with legacy and mobile browser support
Apache License 2.0
642 stars 124 forks source link

Chrome Autofills Security Key #380

Open hanthor opened 3 years ago

hanthor commented 3 years ago

Describe the bug Good Chrome thinks the security key field in Settings is a password field and will autofill

To Reproduce Steps to reproduce the behavior:

  1. Open settings in hydrogen on Google Chrome with a save credentialf ro the site
  2. Chrome will autofile the secutiy key and the search bar with your username and password

Screenshots image

Desktop (please complete the following information):

bwindels commented 3 years ago

Thanks for reporting. I should probably give the password (and other) fields a name attribute :)

aaryan-gautam commented 3 years ago

Can I look into this issue?

MidhunSureshR commented 2 years ago

Here's what MDN says about the autocomplete attribute:

Note: In order to provide autocompletion, user-agents might require <input>/<select>/<textarea> elements to:

  1. Have a name and/or id attribute
  2. Be descendants of a
    element
  3. The form to have a submit button

So to turn off autocomplete for these fields, you would need to wrap the inputs in a <form> tag.