element-hq / matrix-authentication-service

https://element-hq.github.io/matrix-authentication-service/
GNU Affero General Public License v3.0
28 stars 8 forks source link

Links in docs/README.md are broken #1078

Closed matrixbot closed 1 month ago

matrixbot commented 1 month ago

This issue was originally created by @jplatte at https://github.com/matrix-org/matrix-authentication-service/issues/1078.

What the title says.

matrixbot commented 1 month ago

This comment was originally posted by @sandhose at https://github.com/matrix-org/matrix-authentication-service/issues/1078#issuecomment-1506502145.

Right. This file is used in the mdBook published here, where thee links aren't broken: https://matrix-org.github.io/matrix-authentication-service/

I guess we could make those links absolute instead?

matrixbot commented 1 month ago

This comment was originally posted by @jplatte at https://github.com/matrix-org/matrix-authentication-service/issues/1078#issuecomment-1506517528.

Sounds like a good idea.

matrixbot commented 1 month ago

This comment was originally posted by @sandhose at https://github.com/matrix-org/matrix-authentication-service/issues/1078#issuecomment-1757896308.

This actually has been fixed for quite a while, closing

matrixbot commented 1 month ago

This comment was originally posted by @jplatte at https://github.com/matrix-org/matrix-authentication-service/issues/1078#issuecomment-1757904437.

I can still reproduce the problem, clicking on one of the last two links at https://github.com/matrix-org/matrix-authentication-service/tree/main/docs.

matrixbot commented 1 month ago

This comment was originally posted by @sandhose at https://github.com/matrix-org/matrix-authentication-service/issues/1078#issuecomment-1757906540.

Crap, you're right, I wasn't reading the URLs properly :D

matrixbot commented 1 month ago

This comment was originally posted by @sandhose at https://github.com/matrix-org/matrix-authentication-service/issues/1078#issuecomment-1757973443.

I've put placeholders with absolute links to the hosted documentation in them instead of replacing the link in docs/README.md, so that documentation preview doesn't break.